Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19557 )
Change subject: IMPALA-11948: Remove operation logging from getCatalogServerMetrics ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19557/2/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/19557/2/fe/src/main/java/org/apache/impala/common/JniUtil.java@207 PS2, Line 207: logOperation Optional: I would not use the same name as for the public function, would use something like 'logOperationInternal' or '...Helper'. http://gerrit.cloudera.org:8080/#/c/19557/2/fe/src/main/java/org/apache/impala/common/JniUtil.java@219 PS2, Line 219: logOperationSilent I would consider calling it '...SilentStopAndFinish' here also (and also the appropriate functions in JniCatalog.java and JniCatalogOp.java. It is longer but much clearer. -- To view, visit http://gerrit.cloudera.org:8080/19557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd01e9f42ccc6a4adce41caf8884ea3c2c781452 Gerrit-Change-Number: 19557 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 28 Feb 2023 12:18:21 +0000 Gerrit-HasComments: Yes
