Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19561 )
Change subject: IMPALA-11726: Allow LDAP user and group filter when Kerberos is enabled ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java File fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java: http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java@143 PS1, Line 143: return String.format("%s --krb5_ccname=%s", args, testFolder.newFile().getCanonicalPath()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java@146 PS1, Line 146: public int startImpalaClusterWithArgs(String args) throws IOException, InterruptedException { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java@161 PS1, Line 161: .map(entry -> String.format("%s=%s", entry.getKey(), entry.getValue())) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@54 PS1, Line 54: public void testShellKerberosAuthWithCustomLdapFiltersWithSearchBindWithoutGroupFilterCheck() line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@88 PS1, Line 88: public void testShellKerberosAuthWithCustomLdapFiltersWithSearchBindAndGroupFilterCheck() line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@216 PS1, Line 216: public void testLdapFiltersWithProxyWithKerberosAuthAndLdapSearchBind() throws Exception { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@361 PS1, Line 361: public void testShellKerberosAuthWithCustomLdapFiltersWithSimpleBindWithoutGroupFilterCheck() line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@367 PS1, Line 367: String customUserFilter = String.format("%s,%s,another-user", TEST_USER_1, TEST_USER_3); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@414 PS1, Line 414: public void testShellKerberosAuthWithCustomLdapFiltersWithSimpleBindAndGroupFilterCheck() line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@420 PS1, Line 420: String customUserFilter = String.format("%s,%s,another-user", TEST_USER_1, TEST_USER_3); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@492 PS1, Line 492: String customUserFilter = String.format("%s,%s,another-user", TEST_USER_1, TEST_USER_3); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindDefaultFiltersKerberosImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindDefaultFiltersKerberosImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindDefaultFiltersKerberosImpalaShellTest.java@78 PS1, Line 78: public void testDefaultLdapFiltersAreAllowedWithSearchBindAndKerberos() throws Exception { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindKerberosEnabledImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindKerberosEnabledImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindKerberosEnabledImpalaShellTest.java@39 PS1, Line 39: public class LdapSearchBindKerberosEnabledImpalaShellTest extends LdapSearchBindImpalaShellTest { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapSimpleBindKerberosEnabledImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapSimpleBindKerberosEnabledImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/19561/1/fe/src/test/java/org/apache/impala/customcluster/LdapSimpleBindKerberosEnabledImpalaShellTest.java@39 PS1, Line 39: public class LdapSimpleBindKerberosEnabledImpalaShellTest extends LdapSimpleBindImpalaShellTest { line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3ca9c4ff8a17167e5233afabdd14c948edb46de Gerrit-Change-Number: 19561 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Feb 2023 22:39:04 +0000 Gerrit-HasComments: Yes
