Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19572 )
Change subject: IMPALA-11960: Fix constant propagation from TIMESTAMP to DATE ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Thanks Csaba for fixing this. The code change LGTM. One suggestion on adding a test case. http://gerrit.cloudera.org:8080/#/c/19572/2/testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test: http://gerrit.cloudera.org:8080/#/c/19572/2/testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test@439 PS2, Line 439: with dp_view as This test is good. Could you also add one variant of this which has a mix of >= and < in the WHERE clause: e.g where timestamp_col >= '2009-01-01 01:00:00' AND timestamp_col < '2009-02-01 01:00:00' After the rewrite the >= is expected to be preserved and the < is going to change to <=. This is just a sanity check. http://gerrit.cloudera.org:8080/#/c/19572/2/testdata/workloads/functional-query/queries/QueryTest/range-constant-propagation.test File testdata/workloads/functional-query/queries/QueryTest/range-constant-propagation.test: http://gerrit.cloudera.org:8080/#/c/19572/2/testdata/workloads/functional-query/queries/QueryTest/range-constant-propagation.test@14 PS2, Line 14: select count(*), sum(int_col) from alltypes_date_partition Same suggestion as above for the end-to-end test. -- To view, visit http://gerrit.cloudera.org:8080/19572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1938bf5e91057b220daf8a1892940f674aac3d68 Gerrit-Change-Number: 19572 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 22:43:27 +0000 Gerrit-HasComments: Yes
