Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19589 )
Change subject: IMPALA-11974: Fix lazy list operators for Python 3 compatibility ...................................................................... Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/#/c/19589/1/bin/run-workload.py File bin/run-workload.py: http://gerrit.cloudera.org:8080/#/c/19589/1/bin/run-workload.py@175 PS1, Line 175: = > flake8: E712 comparison to False should be 'if cond is False:' or 'if not c Done http://gerrit.cloudera.org:8080/#/c/19589/1/bin/run-workload.py@176 PS1, Line 176: = > flake8: E712 comparison to True should be 'if cond is True:' or 'if cond:' Done http://gerrit.cloudera.org:8080/#/c/19589/1/testdata/common/widetable.py File testdata/common/widetable.py: http://gerrit.cloudera.org:8080/#/c/19589/1/testdata/common/widetable.py@55 PS1, Line 55: > flake8: E271 multiple spaces after keyword Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/comparison/data_generator.py File tests/comparison/data_generator.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/comparison/data_generator.py@189 PS1, Line 189: ) > flake8: E501 line too long (93 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/comparison/query_profile.py File tests/comparison/query_profile.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/comparison/query_profile.py@721 PS1, Line 721: > flake8: E201 whitespace after '[' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/comparison/query_profile.py@721 PS1, Line 721: > flake8: E202 whitespace before ']' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py File tests/query_test/test_decimal_casting.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py@43 PS1, Line 43: > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py@45 PS1, Line 45: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py@45 PS1, Line 45: > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py@45 PS1, Line 45: > flake8: E241 multiple spaces after ':' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py@45 PS1, Line 45: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_decimal_casting.py@47 PS1, Line 47: > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_exprs.py@115 PS1, Line 115: / > flake8: E226 missing whitespace around arithmetic operator Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_insert_parquet.py@637 PS1, Line 637: l > flake8: E501 line too long (96 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/query_test/test_sort.py@30 PS1, Line 30: l > flake8: E741 ambiguous variable name 'l' This looks like a false positive http://gerrit.cloudera.org:8080/#/c/19589/1/tests/stress/test_acid_stress.py File tests/stress/test_acid_stress.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/stress/test_acid_stress.py@76 PS1, Line 76: a > flake8: E501 line too long (94 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/stress/test_acid_stress.py@269 PS1, Line 269: i > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/stress/test_insert_stress.py File tests/stress/test_insert_stress.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/stress/test_insert_stress.py@72 PS1, Line 72: i > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19589/1/tests/util/test_file_parser.py File tests/util/test_file_parser.py: http://gerrit.cloudera.org:8080/#/c/19589/1/tests/util/test_file_parser.py@380 PS1, Line 380: > flake8: E501 line too long (93 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/19589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c082711f8eff451a1b5c085e97461c327edb5f Gerrit-Change-Number: 19589 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 23:20:59 +0000 Gerrit-HasComments: Yes
