Gergely Farkas has posted comments on this change. ( http://gerrit.cloudera.org:8080/19561 )
Change subject: IMPALA-11726: Allow LDAP user and group filter when Kerberos is enabled ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc@284 PS6, Line 284: << "to an impalad."; > You are right. No change then Ok, thanks! http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc@570 PS6, Line 570: const char* requested_user, unsigned rlen, : const char* auth_identity, unsigned alen, : const char* def_realm, unsigned urlen, : struct propctx* propctx) { > nit: Could we keep the original formatting? It is closer to the one used in Thanks for the review! You are right! I've updated these lines. http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc@988 PS6, Line 988: if (FLAGS_enable_ldap_auth || IsKerberosEnabled()) { > Do I understand it right that, this will evaluate to true, then the next co Yes, if both LDAP and Kerberos authentication mode are enabled, the following code snippet will generate 3 callback sets: one for external Kerberos connections, one for internal Kerberos connections and one for Ldap authentication. These callback configurations are used by the GetServerTransportFactory when it creates AuthProvider instances to binary protocols. For Thrift Http protocols, they are not used, but the NegotiateAuth function starting on L714. -- To view, visit http://gerrit.cloudera.org:8080/19561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3ca9c4ff8a17167e5233afabdd14c948edb46de Gerrit-Change-Number: 19561 Gerrit-PatchSet: 6 Gerrit-Owner: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Mar 2023 07:22:17 +0000 Gerrit-HasComments: Yes
