Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19583 )
Change subject: IMPALA-11970: Add query timing display to Impala WebUI ...................................................................... Patch Set 2: Code-Review+1 (1 comment) The CPP code looks OK to me. I'm not expert in reviewing JS code, but looking at the output examples in IMPALA-11970 ticket, I assume it is working fine as well. http://gerrit.cloudera.org:8080/#/c/19583/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/19583/2/be/src/service/impala-http-handler.cc@190 PS2, Line 190: query_timing nit: I think "query_timeline" sounds better, but I'm fine either way. -- To view, visit http://gerrit.cloudera.org:8080/19583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5826107af0f5a7fe306cb986a875cff261d9db Gerrit-Change-Number: 19583 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Mar 2023 23:26:52 +0000 Gerrit-HasComments: Yes
