Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19605 )
Change subject: IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19605/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/19605/2/be/src/service/frontend.cc@85 PS2, Line 85: DEFINE_bool(enable_kudu_impala_hms_check, true, "If enabled checks that Kudu and Impala " > Optional: could mention in the description that the default is true. Done http://gerrit.cloudera.org:8080/#/c/19605/2/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/19605/2/common/thrift/BackendGflags.thrift@240 PS2, Line 240: 104: required bool enable_kudu_impala_hms_check > Is it intentional that we don't add it to the end? Mainly done due to some conflicts. -- To view, visit http://gerrit.cloudera.org:8080/19605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b06935b262e4a314ad631167c1cd33319e4b10f Gerrit-Change-Number: 19605 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Mar 2023 16:29:33 +0000 Gerrit-HasComments: Yes
