Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19601 )
Change subject: IMPALA-11964: Make sure Impala returns error for Iceberg tables with equality deletes ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19601/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19601/2//COMMIT_MSG@22 PS2, Line 22: * added e2e tests Nit: maybe document where the files with equality deletes came from? http://gerrit.cloudera.org:8080/#/c/19601/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19601/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@168 PS2, Line 168: "not supported by Impala: %s", Nit: as this file is just the first we see we could say "not supported by Impala, for example: %s" -- To view, visit http://gerrit.cloudera.org:8080/19601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14d7116692c0e47d0799be650dc323811e2ee0fb Gerrit-Change-Number: 19601 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Thu, 09 Mar 2023 23:02:41 +0000 Gerrit-HasComments: Yes
