Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19483 )

Change subject: IMPALA-11908: Parser change for Iceberg metadata querying
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19483/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/19483/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3341
PS6, Line 3341: addMetadataVirtualTable
> I can't see that the name changed, did you change it?
Thanks for catching this. I did not change it, I added a new condition to the 
Analyzer, I should have made this a precondition.



--
To view, visit http://gerrit.cloudera.org:8080/19483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5db884b5f3fecbd132fcb2c2cbd6c622ff965b
Gerrit-Change-Number: 19483
Gerrit-PatchSet: 6
Gerrit-Owner: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Mar 2023 14:47:05 +0000
Gerrit-HasComments: Yes

Reply via email to