Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19614 )
Change subject: IMPALA-10983: Wait more in wait_for_event_processing if there is progress ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19614/3/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/19614/3/tests/util/event_processor_utils.py@41 PS3, Line 41: timeout > I don't think this function is called directly as a test function, now it i As Daniel wrote the default value is in wait_for_event_processing. http://gerrit.cloudera.org:8080/#/c/19614/3/tests/util/event_processor_utils.py@60 PS3, Line 60: break > We'd better check the status as well by calling get_event_processor_status( Done http://gerrit.cloudera.org:8080/#/c/19614/3/tests/util/event_processor_utils.py@73 PS3, Line 73: > Nit: you used str.format() in the other log messages, but concatenation her I have realized that Python logging has its own way to substitute parameters, switched to using that. -- To view, visit http://gerrit.cloudera.org:8080/19614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676854f7df9aea5fa10fb6ecf6381195bc8fa4b8 Gerrit-Change-Number: 19614 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 16 Mar 2023 12:29:57 +0000 Gerrit-HasComments: Yes
