Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19607 )
Change subject: IMPALA-11942: Restrict trusted_domain=localhost to 127.0.0.1 by default ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19607/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/19607/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@470 PS3, Line 470: testHiveserver2TrustedDomainAuthNonstrict > Do we need to disable this test in some environment? To make this test work consistently, it uses 126.23.0.1 rather than 127.23.0.1 for the nonstrict case. That works in all the test environments I have tried. It would have trouble if it used 127.23.0.1. -- To view, visit http://gerrit.cloudera.org:8080/19607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5915cdd812d461366a421a739c18afecef44fb5b Gerrit-Change-Number: 19607 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Mar 2023 15:53:36 +0000 Gerrit-HasComments: Yes