Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19632
Change subject: IMPALA-5392: Display full Java stacktraces in /jvm-threadz ...................................................................... IMPALA-5392: Display full Java stacktraces in /jvm-threadz jvm-threadz provides information about all the JVM threads running in an Impalad/Catalogd. Currently, this relies on ThreadInfo.toString() for a text representation of the thread information and stack. This output only contains the first few frames, which can be an issue for deeper stacks (e.g. the Catalog talking to HMS via Thrift). The output does contain useful non-stacktrace information like what lock the thread is waiting on. This keeps the first line of the ThreadInfo.toString() output that contains non-stacktrace information. Then it walks through the StackTraceElements from ThreadInfo.getStackTrace() and adds the full stack string. This is intended to mimic the jstack output (with indentation and "at"). To avoid licensing issues, I have not looked at any of the OpenJDK code (which is GPL 2.0) or any of the previous attempts at solving this issue (which consulted OpenJDK code). To make the stacks display correctly in the WebUI page, this puts the thread information in a <span> with "white-space: pre-wrap", which respects the newlines in the original output. Testing: - gdb attached to the HMS and then issued a select in impala-shell to force a metadata load. Then, looked at the catalogd /jvm-threadz page to see the longer stacks. Change-Id: I6730336600a8130e6452c682bcf249cac528ceee --- M fe/src/main/java/org/apache/impala/common/JniUtil.java M www/jvm-threadz.tmpl 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/19632/1 -- To view, visit http://gerrit.cloudera.org:8080/19632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6730336600a8130e6452c682bcf249cac528ceee Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
