Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 )
Change subject: IMPALA-12005: Describe executor group set selection in query profile ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19628/4/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/19628/4/be/src/util/runtime-profile.h@315 PS4, Line 315: RuntimeProfileBase(ObjectPool* pool, const std::string& name, : Counter* total_time_counter, Counter* inactive_timer, : bool add_default_counters = true); : > We could combine two overloaded functions as one by defining the default va Good point. Thanks for the reminder! http://gerrit.cloudera.org:8080/#/c/19628/4/fe/src/main/java/org/apache/impala/service/FrontendProfile.java File fe/src/main/java/org/apache/impala/service/FrontendProfile.java: http://gerrit.cloudera.org:8080/#/c/19628/4/fe/src/main/java/org/apache/impala/service/FrontendProfile.java@187 PS4, Line 187: Preconditions.checkState(profile_ != null, "already emitted profile"); > it's already called in addToCounter() and setToCounter() This is different from addToCounter() and setToCounter(). That one append counter into profile_. addChildrenProfile() intend to add child TRuntimeProfileNode under profile_. This still need to check that profile_ != null (that thrift profile has not been emitted). -- To view, visit http://gerrit.cloudera.org:8080/19628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c0ac7f5216d631e4439fe97702e21e06d2eda8a Gerrit-Change-Number: 19628 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Mar 2023 23:38:21 +0000 Gerrit-HasComments: Yes