Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19641 )
Change subject: IMPALA-12013: Remove future from pkg_resources.py ...................................................................... Patch Set 1: Code-Review+2 (1 comment) This makes sense to me http://gerrit.cloudera.org:8080/#/c/19641/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19641/1//COMMIT_MSG@10 PS1, Line 10: Adding unicode_literals broke reading files : in the HOME directory during package load via pkg_resources when any of : those files contain special characters (above ASCII 127). Can you add a sentence saying that this line was added by us in IMPALA-3343/IMPALA-9489 and was not present in the original pkg_resources.py? (I see we added it here: https://github.com/apache/impala/commit/bc9d7e063dd71f9af75967f8c6af9ac1a6f49149 ) -- To view, visit http://gerrit.cloudera.org:8080/19641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e05904adf9ffe303cac281538df1bbcff5e48b Gerrit-Change-Number: 19641 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 21 Mar 2023 19:01:23 +0000 Gerrit-HasComments: Yes
