Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/19643 )
Change subject: IMPALA-12014 warning on failed KeepAlive for Kudu scanner
......................................................................
Patch Set 3:
> Looks good to me. But build failed, maybe include kudu/util/logging.h
> in kudu-scanner.cc?
Indeed -- I haven't verified it builds since I don't have local impala
workspace for development. I added corresponding include files, hopefully it
builds now. If not, I'll need to setup my dev environment for impala.
43%] Building CXX object
be/src/util/CMakeFiles/UtilIr.dir/min-max-filter-ir.cc.o
/home/ubuntu/Impala/be/src/exec/kudu/kudu-scanner.cc: In member function ‘void
impala::KuduScanner::KeepKuduScannerAlive()’:
/home/ubuntu/Impala/be/src/exec/kudu/kudu-scanner.cc:111:23: error: ‘WARNING’
was not declared in this scope; did you mean ‘google::WARNING’?
111 | KLOG_EVERY_N_SECS(WARNING, 60) << BuildErrorString(
| ^~~~~~~
| google::WARNING
In file included from
/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/glog-0.3.5-p3/include/glog/logging.h:512,
from /home/ubuntu/Impala/be/src/common/logging.h:45,
from /home/ubuntu/Impala/be/src/gutil/casts.h:17,
from /home/ubuntu/Impala/be/src/gutil/hash/hash.h:83,
from
/home/ubuntu/Impala/be/src/kudu/gutil/strings/stringpiece.h:128,
from /home/ubuntu/Impala/be/src/kudu/util/slice.h:24,
from
/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/kudu-345fd44ca3/debug/include/kudu/client/scan_batch.h:37,
from
/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/kudu-345fd44ca3/debug/include/kudu/client/row_result.h:20,
from
/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/kudu-345fd44ca3/debug/include/kudu/client/client.h:38,
from /home/ubuntu/Impala/be/src/exec/kudu/kudu-scanner.h:22,
from /home/ubuntu/Impala/be/src/exec/kudu/kudu-scanner.cc:18:
/home/ubuntu/Impala/toolchain/toolchain-packages-gcc10.4.0/glog-0.3.5-p3/include/glog/log_severity.h:53:29:
note: ‘google::WARNING’ declared here
53 | const int INFO = GLOG_INFO, WARNING = GLOG_WARNING,
| ^~~~~~~
/home/ubuntu/Impala/be/src/exec/kudu/kudu-scanner.cc:111:5: error:
‘KLOG_EVERY_N_SECS’ was not declared in this scope; did you mean ‘LOG_EVERY_N’?
111 | KLOG_EVERY_N_SECS(WARNING, 60) << BuildErrorString(
| ^~~~~~~~~~~~~~~~~
| LOG_EVERY_N
--
To view, visit http://gerrit.cloudera.org:8080/19643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If39f968685797506491d3d5ebc481efb6e43a568
Gerrit-Change-Number: 19643
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 22 Mar 2023 02:20:51 +0000
Gerrit-HasComments: No
