Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 )
Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set ...................................................................... Patch Set 2: (4 comments) A few quick thoughts http://gerrit.cloudera.org:8080/#/c/19645/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19645/2//COMMIT_MSG@10 PS2, Line 10: selection (Frontend.java) should be skipped if If REQUEST_POOL query Nit: remove duplicated "if" http://gerrit.cloudera.org:8080/#/c/19645/2//COMMIT_MSG@11 PS2, Line 11: option is set. Setting REQUEST_POOL means user is determined to let Nit: rather than "determined" maybe we should say they are specifying the pool? http://gerrit.cloudera.org:8080/#/c/19645/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19645/2/fe/src/main/java/org/apache/impala/service/Frontend.java@2118 PS2, Line 2118: addInfoString(groupSetProfile, VERDICT, "Match"); I expected this to be addInfoString(groupSetProfile, VERDICT, reason); as that is what is in the other half of the if http://gerrit.cloudera.org:8080/#/c/19645/2/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19645/2/tests/custom_cluster/test_executor_groups.py@873 PS2, Line 873: ["Executor Group: root.tiny-group", "ExecutorGroupsConsidered: 1"], Should we check for presence of on "Verdict: " as well? -- To view, visit http://gerrit.cloudera.org:8080/19645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf7fe71e2dda1099651b3edf62480e1fdbf845 Gerrit-Change-Number: 19645 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 21:21:12 +0000 Gerrit-HasComments: Yes
