Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 )
Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/19645/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19645/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2107 PS4, Line 2107: st_pool()) { > Just figure out that this might be null. This precondition can be skipped i Done http://gerrit.cloudera.org:8080/#/c/19645/4/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19645/4/tests/custom_cluster/test_executor_groups.py@792 PS4, Line 792: # Force to run the large query on the small group. > This test now success since exec group memory limit is ignored. Changed the assertion. -- To view, visit http://gerrit.cloudera.org:8080/19645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf7fe71e2dda1099651b3edf62480e1fdbf845 Gerrit-Change-Number: 19645 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 23 Mar 2023 04:07:05 +0000 Gerrit-HasComments: Yes
