Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19654 )
Change subject: IMPALA-11954: Fix for URL encoded partition columns for Iceberg tables ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/19654/3/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/19654/3/be/src/exec/hdfs-table-sink.cc@516 PS3, Line 516: url_encoded_partition_name != nullptr); : DCHECK(external_partition_name != null > nit: can you add separate DCHECKs, so if we hit the DCHECK we'll know what Done http://gerrit.cloudera.org:8080/#/c/19654/3/be/src/exec/output-partition.h File be/src/exec/output-partition.h: http://gerrit.cloudera.org:8080/#/c/19654/3/be/src/exec/output-partition.h@70 PS3, Line 70: keys > nit: keys and values Done http://gerrit.cloudera.org:8080/#/c/19654/3/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: http://gerrit.cloudera.org:8080/#/c/19654/3/common/fbs/IcebergObjects.fbs@68 PS3, Line 68: raw_partition_f > nit: raw_partition_fields? or raw_partition_key_values? Done http://gerrit.cloudera.org:8080/#/c/19654/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test: http://gerrit.cloudera.org:8080/#/c/19654/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test@694 PS3, Line 694: ---- RUNTIME_PROFILE > Could you please add RUNTIME_PROFILE to check partition pruning? Done -- To view, visit http://gerrit.cloudera.org:8080/19654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67edc3d04738306fed0d4ebc5312f3d8d4f14254 Gerrit-Change-Number: 19654 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Mar 2023 14:55:57 +0000 Gerrit-HasComments: Yes
