Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19656 )
Change subject: IMPALA-12029: Relax scan fragment parallelism on first planning ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/19656/8/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19656/8/fe/src/main/java/org/apache/impala/service/Frontend.java@2110 PS8, Line 2110: addCounter(groupSetProfile, new TCounter(CPU_MAX, TUnit.UNIT, available_cores)); Should we check if ProcessingCost.isComputeCost(queryOptions) is true when adding CPU_MAX counter ? http://gerrit.cloudera.org:8080/#/c/19656/8/fe/src/main/java/org/apache/impala/service/Frontend.java@2144 PS8, Line 2144: if (memoryAskUnbounded > 0) { : addCounter(groupSetProfile, : new TCounter(MEMORY_ASK_UNBOUNDED, TUnit.BYTES, memoryAskUnbounded)); : memoryAskUnbounded = -1; : } : if (cpuAskUnbounded > 0) { : addCounter(groupSetProfile, : new TCounter(CPU_ASK_UNBOUNDED, TUnit.UNIT, cpuAskUnbounded)); : cpuAskUnbounded = -1; : } move this code block in front of line 2142 '}" ? -- To view, visit http://gerrit.cloudera.org:8080/19656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a2276fbd344d00caa67103026661a3644b9a1f9 Gerrit-Change-Number: 19656 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Mar 2023 23:10:12 +0000 Gerrit-HasComments: Yes
