Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19661 )
Change subject: IMPALA-12031: Add security-related HTTP headers ...................................................................... Patch Set 1: (2 comments) Looks good, I have one suggestion then should be GTG http://gerrit.cloudera.org:8080/#/c/19661/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19661/1//COMMIT_MSG@9 PS1, Line 9: These are primarily no-ops as Impala never serves HTTP and HTTPS at the Can you list the new headers here? http://gerrit.cloudera.org:8080/#/c/19661/1/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/19661/1/be/src/util/webserver-test.cc@308 PS1, Line 308: string cmd = Substitute("curl -v -f -s --cacert $0 'https://localhost:$1' 2>&1", I see curl is installed by boostrap_system.sh so this should be OK -- To view, visit http://gerrit.cloudera.org:8080/19661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58e12961e7faa31f42bc2e6bd4de23b56e3dfd5f Gerrit-Change-Number: 19661 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Mar 2023 16:22:28 +0000 Gerrit-HasComments: Yes
