Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19656 )
Change subject: IMPALA-12029: Relax scan fragment parallelism on first planning ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/19656/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19656/11//COMMIT_MSG@33 PS11, Line 33: - Use NUM_SCANNER_THREADS as a hint to cap scan node cost > I think this should only be applied on first iteration and not applied when Done http://gerrit.cloudera.org:8080/#/c/19656/11/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/19656/11/fe/src/main/java/org/apache/impala/planner/ScanNode.java@378 PS11, Line 378: long syntheticPerRowCost = Lon > can return directly Done http://gerrit.cloudera.org:8080/#/c/19656/11/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19656/11/tests/custom_cluster/test_executor_groups.py@974 PS11, Line 974: that high_scan_cost_qu > nit: that high_scan_cost_query Done http://gerrit.cloudera.org:8080/#/c/19656/11/tests/custom_cluster/test_executor_groups.py@976 PS11, Line 976: options['NUM_SCANNER_THREADS'] = '1' > nit: duplicated line. Done -- To view, visit http://gerrit.cloudera.org:8080/19656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a2276fbd344d00caa67103026661a3644b9a1f9 Gerrit-Change-Number: 19656 Gerrit-PatchSet: 13 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Mar 2023 21:42:22 +0000 Gerrit-HasComments: Yes
