Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19651 )
Change subject: IMPALA-11985: [DOCS] Support for Kudu's multi-rows transaction ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19651/5/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: http://gerrit.cloudera.org:8080/#/c/19651/5/docs/topics/impala_kudu.xml@1421 PS5, Line 1421: This flag is set to : False by default. > kudu_ignore_conflicts_in_transaction flag is only considered if kudu_ignore Yep, as Wenzhe mentioned, the point here is to allow people know that --kudu_ignore_conflicts_in_transaction=true is taken into consideration only when --kudu_ignore_conflicts=true (those are two different runtime flags). Basically, --kudu_ignore_conflicts_in_transaction is gated by --kudu_ignore_conflicts, so I thought whether it makes sense to mention that in this doc. It's up to you to make a call, though. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/19651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic226679d83d7221f843994ead11cb2bc9e971882 Gerrit-Change-Number: 19651 Gerrit-PatchSet: 5 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Mar 2023 22:54:19 +0000 Gerrit-HasComments: Yes
