Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19652 )
Change subject: IMPALA-12025: Hide misleading TotalTime and InactiveTotalTime ...................................................................... IMPALA-12025: Hide misleading TotalTime and InactiveTotalTime RuntimeProfileBase class in runtime-profile.cc always include TotalTime and InactiveTotalTime counter to query profile. These are being used to measure fragment instance activities, but meaningless and potentially misleading in some other parts of query profile. THis patch hide TotalTime and InactiveTotalTime in the following runtime profile nodes: - Right under "Query" (first line) - All under "Summary:" and "ImpalaServer:" - "Execution Profile" - All under "Per Node Profiles:" except for "CodeGen:" - "Fragment Instance Lifecycle Timings:" - "Buffer pool:" - "Dequeue:" and "Enqueue:" - "Hash Table:" - "Filter x:" - "GroupingAggregator x:" Testing: - Pass core tests. Change-Id: I32e68d36549f9730c08232fbc270e518f2acaffa Reviewed-on: http://gerrit.cloudera.org:8080/19652 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/aggregator.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/hash-table.cc M be/src/exec/scan-node.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/fragment-state.cc M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/query-state.cc M be/src/service/client-request-state.cc M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h 14 files changed, 122 insertions(+), 74 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I32e68d36549f9730c08232fbc270e518f2acaffa Gerrit-Change-Number: 19652 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
