Hello Quanlong Huang, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19712
to look at the new patch set (#3).
Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift
JNI
......................................................................
IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI
Large results from something like COMPUTE INCREMENTAL STATS can result
in "TTransportException: MaxMessageSize reached". This happens when
CatalogdMetaProvider.updateCatalogCache() receives a buffer through the
JNI from NativeGetNextCatalogObjectUpdate that exceeds 100MB.
TByteBuffer inherits from TEndpointTransport, which in Thrift 0.16.0
adds a MaxMessageSize limit. TMemoryBuffer adds a constructor that
allows passing in a TConfiguration object to customize the limit, which
we make use of in IMPALA-11669, but TByteBuffer does not provide a
similar interface (THRIFT-5696) and was overlooked.
This patch fix the issue by copying
org.apache.thrift.transport.TByteBuffer from thrift-0.16.0 to
org.apache.impala.util.TByteBuffer and patch it with fix from
THRIFT-5696. It then pass thrift_rpc_max_message_size value as a
TConfiguration to the TByteBuffer constructor.
Testing:
- Pass CatalogdMetaProviderTest tests.
Change-Id: I105db332cd312d80bac0313090576bc47064ee16
---
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
A fe/src/compat-apache-hive-3/java/org/apache/thrift/TConfiguration.java
A
fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
A fe/src/main/java/org/apache/impala/util/TByteBuffer.java
M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
9 files changed, 379 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/19712/3
--
To view, visit http://gerrit.cloudera.org:8080/19712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I105db332cd312d80bac0313090576bc47064ee16
Gerrit-Change-Number: 19712
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
