Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 )
Change subject: IMPALA-10851: Codegen for structs ...................................................................... Patch Set 18: (5 comments) http://gerrit.cloudera.org:8080/#/c/18526/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18526/18//COMMIT_MSG@31 PS18, Line 31: - enabled codegen in other tests where it used to be disabled because : it was not supported. another test that disabled codegen due to structs: https://github.com/apache/impala/blob/32aeeecc078015263a1282f631acde4df6bd789c/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java#L3228 http://gerrit.cloudera.org:8080/#/c/18526/18/be/src/codegen/codegen-anyval-read-write-info.cc File be/src/codegen/codegen-anyval-read-write-info.cc: http://gerrit.cloudera.org:8080/#/c/18526/18/be/src/codegen/codegen-anyval-read-write-info.cc@139 PS18, Line 139: codegen_->GetFunction(IRFunction::GET_FUNCTION_CTX, false); nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/18526/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/18526/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@774 PS18, Line 774: AnalysisContext ctx = createAnalysisCtx(); : ctx.getQueryOptions().setDisable_codegen(true); Can also run with codegen http://gerrit.cloudera.org:8080/#/c/18526/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@803 PS18, Line 803: ctx.getQueryOptions().setDisable_codegen(true); Can also run with codegen http://gerrit.cloudera.org:8080/#/c/18526/18/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/18526/18/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@806 PS18, Line 806: TQueryOptions queryOpts = defaultQueryOptions(); : queryOpts.setDisable_codegen(true); Can also run with codegen -- To view, visit http://gerrit.cloudera.org:8080/18526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 18 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 14:18:46 +0000 Gerrit-HasComments: Yes
