Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19534 )
Change subject: IMPALA-11701 Part1: Don't push down predicates to scanner if already applied by Iceberg ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/19534/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19534/8//COMMIT_MSG@20 PS8, Line 20: materialize less slots > We don't have the query rewrite yet, but probably we still get the Parquet You're right, the Parquet scanner goes into the "count * optimisation path" and the query is answered from stats if there are no predicates pushed down for a count * query. I added a test to cover this. http://gerrit.cloudera.org:8080/#/c/19534/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/19534/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@64 PS1, Line 64: super(id, tblRef.getDesc(), conjuncts, > Though if we have the following case: Ahh, good point. No worries, I'll re-retire 'nonIdentityConjuncts_' then :) http://gerrit.cloudera.org:8080/#/c/19534/9/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19534/9/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@503 PS9, Line 503: anyMatch > Nit: instead of negating anyMatch, you could use noneMatch. Done Update: Anyway, I restored this function to the original version so this is not relevant anymore. -- To view, visit http://gerrit.cloudera.org:8080/19534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa80ce469cecfcfbcd0dcb595a6b04b7027285b Gerrit-Change-Number: 19534 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Apr 2023 07:26:00 +0000 Gerrit-HasComments: Yes