Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )
Change subject: IMPALA-12077: Remove deprecated Avro methods ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19772/1/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java File fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java: http://gerrit.cloudera.org:8080/#/c/19772/1/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java@112 PS1, Line 112: createAvroSchema(impalaType), fs.getComment(), null); This causes test_avro_schema_resolution.py to fail because fields with a null value are omitted. Updating it to Schema.NULL_VALUE looks like it should work. -- To view, visit http://gerrit.cloudera.org:8080/19772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c Gerrit-Change-Number: 19772 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Apr 2023 16:32:29 +0000 Gerrit-HasComments: Yes
