Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19744 )
Change subject: IMPALA-11970: Optimized rendering for the query timeline display ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/19744/9/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/9/www/query_timeline.tmpl@82 PS9, Line 82: var profile_available = > Remove this line since plan_order should be local variable in renderTiming( The declaration has been removed. http://gerrit.cloudera.org:8080/#/c/19744/9/www/query_timeline.tmpl@128 PS9, Line 128: maxts = 0; > It seems checkbox "Print tree in plan order" is not working now. When the b The plan_order declaration has been moved to line 289 now, and will be initialized each time, not only during the initial collection of profile attributes. If other events change the checkbox values in between a call to renderTiming(), the order will remain same, while affecting subsequent renders. -- To view, visit http://gerrit.cloudera.org:8080/19744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec458602266863b6e313f52b26a2dc35cff0db0f Gerrit-Change-Number: 19744 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 03:30:59 +0000 Gerrit-HasComments: Yes
