Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 )
Change subject: IMPALA-6433: Add read support for PageHeaderV2 ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19793/3/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/19793/3/be/src/exec/parquet/parquet-column-chunk-reader.cc@297 PS3, Line 297: // https://github.com/apache/parquet-format/blob/2a481fe1aad64ff770e21734533bb7ef5a057dac/src/main/thrift/parquet.thrift#L578 line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/19793/3/be/src/exec/parquet/parquet-column-chunk-reader.cc@329 PS3, Line 329: parent_->scan_node_->UpdateBytesRead(slot_id_, orig_uncompressed_size, orig_compressed_size); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19793/3/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/19793/3/tests/query_test/test_scanners.py@1919 PS3, Line 1919: class TestParquetV2(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/19793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I282962a6e4611e2b662c04a81592af83ecaf08ca Gerrit-Change-Number: 19793 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 16:16:06 +0000 Gerrit-HasComments: Yes
