Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support ...................................................................... Patch Set 6: (5 comments) Addressed comments. Modified the script to set up HDFS short circuit read. http://gerrit.cloudera.org:8080/#/c/18939/5/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18939/5/CMakeLists.txt@513 PS5, Line 513: install(DIRECTORY fe/target/dependency/ DESTINATION ${IMPALA_INSTALLDIR}/jar : FILES_MATCHING PATTERN "*.jar") > Nit: the regular build statically links this, so it may not be necessary. Done http://gerrit.cloudera.org:8080/#/c/18939/5/CMakeLists.txt@523 PS5, Line 523: add_custom_target(gen-deps ALL DEPENDS thrift-deps proto-deps fb-deps : kudu-util-proto-deps kudu-rpc-proto-deps kudu-security-proto-de > Nit: the regular build statically links this, so it may not be necessary. Done http://gerrit.cloudera.org:8080/#/c/18939/5/CMakeLists.txt@618 PS5, Line 618: # libsasl2-modules-gssapi-mit will include dependencies o > For the docker build, we also strip the kudu client share library and the l I tried adding the so files but they are not stripped. Later I realized this variable is changed to boolean type and all files except external libs will be stripeed: https://cmake.cmake.narkive.com/jj2FbwKG/cpack-strip-files-not-working-for-files-not-built-by-project We need additional works to strip the external so files. Is it ok to do it in a separate JIRA? http://gerrit.cloudera.org:8080/#/c/18939/5/CMakeLists.txt@628 PS5, Line 628: > How do we decide what belongs on this list? Good point! Updated this list. http://gerrit.cloudera.org:8080/#/c/18939/5/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18939/5/be/CMakeLists.txt@712 PS5, Line 712: > The llvm-ir bytecode is baked into the impalad executable, so it isn't nece Thanks for pointing this out! -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 02:56:11 +0000 Gerrit-HasComments: Yes
