Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 )
Change subject: IMPALA-6433: Add read support for PageHeaderV2 ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/19793/9/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/19793/9/be/src/exec/parquet/parquet-column-chunk-reader.cc@286 PS9, Line 286: Status ParquetColumnChunkReader::ProcessRepDefLevelsInDataPageV2(const parquet::DataPageHeaderV2* header_v2, line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/19793/9/be/src/exec/parquet/parquet-column-chunk-reader.cc@333 PS9, Line 333: RETURN_IF_ERROR(ProcessRepDefLevelsInDataPageV2(&header.data_page_header_v2, page_info, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19793/9/be/src/exec/parquet/parquet-column-chunk-reader.cc@337 PS9, Line 337: // https://github.com/apache/parquet-format/blob/2a481fe1aad64ff770e21734533bb7ef5a057dac/src/main/thrift/parquet.thrift#L578 line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/19793/9/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/19793/9/tests/query_test/test_scanners_fuzz.py@170 PS9, Line 170: flake8: E221 multiple spaces before operator -- To view, visit http://gerrit.cloudera.org:8080/19793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I282962a6e4611e2b662c04a81592af83ecaf08ca Gerrit-Change-Number: 19793 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 03 May 2023 18:17:29 +0000 Gerrit-HasComments: Yes
