Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 )
Change subject: IMPALA-11064 Optimizing Temporary File Structure for Batch Reading ...................................................................... Patch Set 11: (2 comments) Rebased and added more testcases. http://gerrit.cloudera.org:8080/#/c/18219/10/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/18219/10/be/src/exec/partitioned-hash-join-builder.cc@181 PS10, Line 181: base_spill_id_(PhjBuilderConfig::GenerateBaseSpillId( > nit: Indentation's wrong here. Done http://gerrit.cloudera.org:8080/#/c/18219/10/be/src/exec/partitioned-hash-join-builder.cc@182 PS10, Line 182: state->query_options().base_spill_id_level, (uint64_t)this)) { > nit: Should have a space after closing parens. Done -- To view, visit http://gerrit.cloudera.org:8080/18219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If913785cac9e2dafa20013b6600c87fcaf3e2018 Gerrit-Change-Number: 18219 Gerrit-PatchSet: 11 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 11 May 2023 17:46:56 +0000 Gerrit-HasComments: Yes
