Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19875 )
Change subject: IMPALA-12134: Optimize row materialization time ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19875/1/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/19875/1/be/src/runtime/timestamp-parse-util.cc@236 PS1, Line 236: ZeroPad(dst, d.year(), 4); : ZeroPad(dst + 5, d.month().as_number(), 2); : ZeroPad(dst + 8, d.day(), 2); I think that this could be faster if year/month/day were calculated in a single function call like in DateParser::FormatDefault. similarly, probably the time could be also split up more efficiently to hour/minute/second/nanos, but I don't know about a functions that does this -- To view, visit http://gerrit.cloudera.org:8080/19875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ef5e4137fa6c2d0a5f08b430e01e3fb7de86330 Gerrit-Change-Number: 19875 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 11 May 2023 21:35:42 +0000 Gerrit-HasComments: Yes
