Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19877 )

Change subject: IMPALA-12123 (part 2): Fix offsets for HDFS caching with 
subranges
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Thanks for finding and fixing this bug!

http://gerrit.cloudera.org:8080/#/c/19877/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19877/1//COMMIT_MSG@19
PS1, Line 19:  - In a local minicluster, creating a table based on
            :    alltypes_tiny_pages.parquet, added HDFS caching for the table,
            :    ran the SQLs in parquet-page-index-alltypes-tiny-pages.test,
            :    and checked the HDFS caching reads in the profile.
Would it be possible to add an e2e test for this?



--
To view, visit http://gerrit.cloudera.org:8080/19877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0ccc677b090ef3a75047defb4d7bda4279dac6
Gerrit-Change-Number: 19877
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 12 May 2023 12:33:41 +0000
Gerrit-HasComments: Yes

Reply via email to