Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 )
Change subject: IMPALA-6433: Add read support for PageHeaderV2 ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/19793/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19793/13//COMMIT_MSG@77 PS13, Line 77: Note that no test is added where some pages are compressed while > This is not going to be resolved in this patch right? It could be described modifies the comment - I don't think that a Jira is needed for this as it looks a very unlikely case http://gerrit.cloudera.org:8080/#/c/19793/13/be/src/exec/parquet/parquet-column-chunk-reader.h File be/src/exec/parquet/parquet-column-chunk-reader.h: http://gerrit.cloudera.org:8080/#/c/19793/13/be/src/exec/parquet/parquet-column-chunk-reader.h@126 PS13, Line 126: returns an error > It DCHECKs, doesn't return an error. It actually does - added a comment in the .cc about how. http://gerrit.cloudera.org:8080/#/c/19793/13/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/19793/13/be/src/exec/parquet/parquet-column-chunk-reader.cc@384 PS13, Line 384: c > Consider opening a Jira for it and referencing it here. Done -- To view, visit http://gerrit.cloudera.org:8080/19793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I282962a6e4611e2b662c04a81592af83ecaf08ca Gerrit-Change-Number: 19793 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 12:53:07 +0000 Gerrit-HasComments: Yes
