Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19879 )
Change subject: IMPALA-12138: Optimize HS2 result vector allocations ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19879/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19879/3//COMMIT_MSG@21 PS3, Line 21: Also noticed that the current default fetch_size=10240 in impala-shell > Should mention that the fetch_size has been changed. This patch doesn't change the default - created IMPALA-12142 to track this. http://gerrit.cloudera.org:8080/#/c/19879/3//COMMIT_MSG@23 PS3, Line 23: not a pow > Nit: not a power Done http://gerrit.cloudera.org:8080/#/c/19879/3/be/src/service/hs2-util.h File be/src/service/hs2-util.h: http://gerrit.cloudera.org:8080/#/c/19879/3/be/src/service/hs2-util.h@36 PS3, Line 36: /// Evaluate 'expr_eval' over the row [start_idx, start_idx + num_rows) from 'batch' into > Should mention 'expected_result_count' in the comment. Done -- To view, visit http://gerrit.cloudera.org:8080/19879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b0e6a0a8fd028e3c0e4f1f4e272a50d2bfb59ba Gerrit-Change-Number: 19879 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 12:22:54 +0000 Gerrit-HasComments: Yes
