Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19894 )

Change subject: WIP: Optimize delimited output
......................................................................


Patch Set 1:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py
File shell/shell_output.py:

http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@86
PS1, Line 86:
flake8: E222 multiple spaces after operator


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@86
PS1, Line 86:
flake8: E272 multiple spaces before keyword


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@87
PS1, Line 87: .
flake8: E501 line too long (106 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@88
PS1, Line 88: s
flake8: E501 line too long (109 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@89
PS1, Line 89:
flake8: E222 multiple spaces after operator


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@90
PS1, Line 90:
flake8: E272 multiple spaces before keyword


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@94
PS1, Line 94: =
flake8: E225 missing whitespace around operator


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@95
PS1, Line 95:
flake8: E222 multiple spaces after operator


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@127
PS1, Line 127:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@127
PS1, Line 127:     return result
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@202
PS1, Line 202: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/19894/1/shell/shell_output.py@219
PS1, Line 219: o
flake8: E111 indentation is not a multiple of 2



--
To view, visit http://gerrit.cloudera.org:8080/19894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I671c6f538c588f8ad4ef4067f7bc8a6b8a5220cb
Gerrit-Change-Number: 19894
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 16 May 2023 15:12:21 +0000
Gerrit-HasComments: Yes

Reply via email to