Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19928 )
Change subject: IMPALA-11253: Support testing with Java 11 (take 2) ...................................................................... Patch Set 1: (1 comment) This is looking good http://gerrit.cloudera.org:8080/#/c/19928/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19928/1//COMMIT_MSG@36 PS1, Line 36: This reverts commit 1b6011c6a08123bb15921add253074dca7b4d390. If I'm understanding this properly, the problem with the first patch was that IMPALA_JDK_VERSION='system' was getting converted to IMPALA_JDK_VERSION=8 by the code here: https://github.com/apache/impala/commit/ee6395db760e6629442c7e3fdda34519c61641c5#diff-fc0aa0b99cb982f212166f43bf69341f2a2a9af15401b3b8d4b09b4a4a3c6225R459-R468 Can we add a sentence saying that we fixed this issue with the original patch? -- To view, visit http://gerrit.cloudera.org:8080/19928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie16504ad5738b1f228f97044afd3d9017ccc6c53 Gerrit-Change-Number: 19928 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 24 May 2023 21:39:40 +0000 Gerrit-HasComments: Yes
