Anonymous Coward (767) has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 )
Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView ...................................................................... Patch Set 5: Code-Review+1 (9 comments) Looks great! --Qifan http://gerrit.cloudera.org:8080/#/c/19768/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19768/5//COMMIT_MSG@14 PS5, Line 14: but still need to be evaluated in the current scope. The bug is due to nit. as demonstrated with the following query http://gerrit.cloudera.org:8080/#/c/19768/5//COMMIT_MSG@17 PS5, Line 17: Such as sql: nit. remove http://gerrit.cloudera.org:8080/#/c/19768/5//COMMIT_MSG@18 PS5, Line 18: WITH detail_measure AS ( : SELECT : * : FROM : ( : VALUES : ( : 1 AS `isqbiuar`, : 1 AS `bgsfrbun`, : 1 AS `result_type`, : 1 AS `bjuzzevg` : ), : (2, 2, 2, 2) : ) a : ), : order_measure_sql0 AS ( : SELECT : row_number() OVER ( : ORDER BY : row_number_0 DESC NULLS LAST, : isqbiuar ASC NULLS LAST : ) AS `row_number_0`, : `isqbiuar` : FROM : ( : VALUES : (1 AS `row_number_0`, 1 AS `isqbiuar`), : (2, 2) : ) b : ) : SELECT : detail_measure.`isqbiuar` AS `isqbiuar`, : detail_measure.`bgsfrbun` AS `bgsfrbun`, : detail_measure.`result_type` AS `result_type`, : detail_measure.`bjuzzevg` AS `bjuzzevg`, : `row_number_0` AS `row_number_0` : FROM : detail_measure : LEFT JOIN order_measure_sql0 : ON order_measure_sql0.isqbiuar = detail_measure.isqbiuar : WHERE : row_number_0 BETWEEN 1 : AND 1 : ORDER BY : `row_number_0` ASC NULLS LAST, : `bgsfrbun` ASC NULLS LAST indent for better readability. http://gerrit.cloudera.org:8080/#/c/19768/5//COMMIT_MSG@65 PS5, Line 65: current query nit. current incorrect result http://gerrit.cloudera.org:8080/#/c/19768/5//COMMIT_MSG@73 PS5, Line 73: query nit. remove http://gerrit.cloudera.org:8080/#/c/19768/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/19768/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1410 PS5, Line 1410: Migrates nit. Migrate http://gerrit.cloudera.org:8080/#/c/19768/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1423 PS5, Line 1423: Migrate predicates into view: {}. Copy predicates into view: {} nit. Assign predicates for view: migrating {}, coping {}. http://gerrit.cloudera.org:8080/#/c/19768/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1432 PS5, Line 1432: would nit. can be assigned http://gerrit.cloudera.org:8080/#/c/19768/5/testdata/workloads/functional-planner/queries/PlannerTest/analytic-rank-pushdown.test File testdata/workloads/functional-planner/queries/PlannerTest/analytic-rank-pushdown.test: http://gerrit.cloudera.org:8080/#/c/19768/5/testdata/workloads/functional-planner/queries/PlannerTest/analytic-rank-pushdown.test@2036 PS5, Line 2036: pushed down Can you say something about the retained aspect of these predicates in the comment too? -- To view, visit http://gerrit.cloudera.org:8080/19768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6c209b2a64bad37d893ba8b520342bf1f9a7513 Gerrit-Change-Number: 19768 Gerrit-PatchSet: 5 Gerrit-Owner: Minghui Zhu <huihui.cod...@gmail.com> Gerrit-Reviewer: Anonymous Coward (767) Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Minghui Zhu <huihui.cod...@gmail.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Wed, 31 May 2023 15:00:55 +0000 Gerrit-HasComments: Yes
