Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19990 )
Change subject: IMPALA-12158: Restore process name for daemons ...................................................................... Patch Set 3: (2 comments) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/19990/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19990/3/be/src/common/init.cc@358 PS3, Line 358: char* current_val_c = getenv("LIBHDFS_OPTS"); > This could also be JAVA_TOOL_OPTIONS. No specific reason I chose this one. Would be nice to keep every option in a single variable, so we could easily lookup the options in /proc/PID/environ. But I see we already use both JAVA_TOOL_OPTIONS and LIBHDFS_OPTS, not sure if it would be OK to only use one. http://gerrit.cloudera.org:8080/#/c/19990/3/fe/src/main/java/org/apache/impala/util/ThreadNameAnnotator.java File fe/src/main/java/org/apache/impala/util/ThreadNameAnnotator.java: http://gerrit.cloudera.org:8080/#/c/19990/3/fe/src/main/java/org/apache/impala/util/ThreadNameAnnotator.java@49 PS3, Line 49: thr_.getName() Normally it shouildn't be null I think, but still it'd probably be more safe to invoke equals in reverse: "main".equals(thr_.getName()) -- To view, visit http://gerrit.cloudera.org:8080/19990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7469b4f595acc1949286520a8e6086716bec0b1f Gerrit-Change-Number: 19990 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:42:54 +0000 Gerrit-HasComments: Yes
