Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 )
Change subject: IMPALA-12171: Optimize delimited output ...................................................................... Patch Set 6: (4 comments) Thanks for doing this optimization! http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py@105 PS6, Line 105: or result.find(quote) != -1: Currently we can't turn the try_quick_path flag back to True once it's turned off by error. It'd be nice to add an "unsafe" option for impala-shell to always (blindly) skip these checks. So we can know how well we can achieve in our best. On the other side, if users believe their strings are simple, they can use the "unsafe" option to futher boost the performance. http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py@123 PS6, Line 123: pass nit: don't need 'pass' http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py@149 PS6, Line 149: self.try_quick_path = False For supportability, we need to know when (and wound be perfect to have "why") this is turned off. Or just print it if verbose=true. http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/19894/6/tests/shell/test_shell_commandline.py@1628 PS6, Line 1628: Can we add tests for decoding errors? We can use the queries in test_utf8_decoding_error_handling(), e.g. select unhex('aa') -- To view, visit http://gerrit.cloudera.org:8080/19894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671c6f538c588f8ad4ef4067f7bc8a6b8a5220cb Gerrit-Change-Number: 19894 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 09:14:25 +0000 Gerrit-HasComments: Yes
