Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19997 )
Change subject: IMPALA-12178: Refined alignment for timeticks in query timeline ...................................................................... Patch Set 1: > The code change looks good to me. > One question for the ending time on timetick lables. I ran a query. > The duration shown on query/plan/summary pages are 6s450ms, but the > ending time shown on timetick is 1.53. It's a bit confusing. The timeticks were being retrieved from the fragment events and are only updated in query profile after certain duration. The node with PLAN_ROOT_SINK consumes more time to send all the retrieved rows to the user. This time is included in fragment events only after the query ends. The timeticks may be displayed with other mechanisms, but this would disturb the relation with fragment events. -- To view, visit http://gerrit.cloudera.org:8080/19997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia74433219e09993b1b0326027d86c2f96bb88639 Gerrit-Change-Number: 19997 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 08:18:00 +0000 Gerrit-HasComments: No
