Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20037
to look at the new patch set (#2).
Change subject: IMPALA-12204: Fix redundant codegen info added in subplan
profiles
......................................................................
IMPALA-12204: Fix redundant codegen info added in subplan profiles
The SUBPLAN node will open its right child node many times in its
GetNext(), depending on how many rows generated from its left child. The
right child of a SUBPLAN node is a subtree of operators. They should not
add codegen info into profile in their Open() method since it will be
invoked repeatedly.
Currently, DataSink and UnionNode have such an issue. This patch fixes
them by adding the codegen info to profile in Close() instead of Open(),
just like what we did in IMPALA-11200.
Tests:
- Add e2e tests
Change-Id: I99a0a842df63a03c61024e2b77d5118ca63a2b2d
---
M be/src/exec/data-sink.cc
M be/src/exec/union-node.cc
M be/src/runtime/fragment-state.h
M
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan-single-node.test
M
testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test
5 files changed, 51 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/20037/2
--
To view, visit http://gerrit.cloudera.org:8080/20037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a0a842df63a03c61024e2b77d5118ca63a2b2d
Gerrit-Change-Number: 20037
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
