Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20062
Change subject: IMPALA-12202: Replace lsb_release with /etc/os-release ...................................................................... IMPALA-12202: Replace lsb_release with /etc/os-release This switches the code in init.sh to use /etc/os-release rather than lsb_release. /etc/os-release is available on all supported Linux distributions, and it provides the same information. There is a database of /etc/os-release files at https://github.com/chef/os_release that helps find the right comparisons. This does not change existing Docker images to stop installing lsb_release, because sometimes older native-toolchain branches build on newer Docker images. However, it does mean that future OSes added (like Redhat 9 and Ubuntu 22) will not need to provide lsb_release. To support that use case, this adds the --no-lsb-rlease flag to assert-dependencies-present.py, which tells it that lsb_release is not required. Existing images do not specify that flag, so lsb_release is still verified. This removes the RELEASE_NAME environment variable and obsolete code that used it. It also adds an assertion that the utility 'cmp' is present. This is currently provided as a transitive dependency of lsb_release, but any new distribution without lsb_release will need to get it directly. Testing: - Built new docker images and ran builds with them Change-Id: I3aecaf0fddf27e2a8fbff00a772d6a1cdc6fd7eb --- M docker/all/assert-dependencies-present.py M functions.sh M init.sh M source/llvm/build-source-tarball.sh 4 files changed, 33 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/62/20062/1 -- To view, visit http://gerrit.cloudera.org:8080/20062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3aecaf0fddf27e2a8fbff00a772d6a1cdc6fd7eb Gerrit-Change-Number: 20062 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
