Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20040 )
Change subject: IMPALA-12200: Cap stats NDV from SetOperationStmt.createMetadata ...................................................................... Patch Set 5: (1 comment) Patch set 5 change the interface to have a variant of ColumnStats.fromExpr() that may return stats with lower numDistinctValue if it has intersection with known column from prior expressions. This patch set pass core tests. http://gerrit.cloudera.org:8080/#/c/20040/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/20040/4/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@217 PS4, Line 217: return path_.getVirtualColumnType(); > Ran core tests again last night and some test fail assertion here. Turns ou Refactored. -- To view, visit http://gerrit.cloudera.org:8080/20040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bb2eff5005fdfb11adf31499214c63dd552c05 Gerrit-Change-Number: 20040 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 06:00:16 +0000 Gerrit-HasComments: Yes