Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 )
Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables ...................................................................... Patch Set 6: (4 comments) Looks nice. I saw that there were already some concerns regarding recovering from failures. Marked some from sub-query side. http://gerrit.cloudera.org:8080/#/c/19397/6/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19397/6/be/src/service/client-request-state.cc@2152 PS6, Line 2152: { I think we should try to revert the table name if the query status is not ok. http://gerrit.cloudera.org:8080/#/c/19397/6/be/src/service/client-request-state.cc@2187 PS6, Line 2187: { We should notify the user in case the query status is not ok if the clean up part is failed. http://gerrit.cloudera.org:8080/#/c/19397/6/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19397/6/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@138 PS6, Line 138: public static final String METADATA_FOLDER_NAME = "metadata"; nit: this way it gives the impression that the above comment is related http://gerrit.cloudera.org:8080/#/c/19397/6/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/19397/6/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@65 PS6, Line 65: nit: comment -- To view, visit http://gerrit.cloudera.org:8080/19397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e6a9cfe099c263f17b5506d6db459b79ad31a5 Gerrit-Change-Number: 19397 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Jun 2023 12:48:17 +0000 Gerrit-HasComments: Yes
