Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20118 )
Change subject: IMPALA-12242: Fix failover case in bin/cmake_aux/create_py3_virtualenv.sh ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20118/3/bin/cmake_aux/create_py3_virtualenv.sh File bin/cmake_aux/create_py3_virtualenv.sh: http://gerrit.cloudera.org:8080/#/c/20118/3/bin/cmake_aux/create_py3_virtualenv.sh@47 PS3, Line 47: if $IS_PY36_OR_HIGHER ; then > nit: this could be merged into the last conditional. They check the same th Good point, merged these two -- To view, visit http://gerrit.cloudera.org:8080/20118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic20d5b2fba3da3c5358e3ab5513885389bb9eeaa Gerrit-Change-Number: 20118 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Sat, 24 Jun 2023 19:31:21 +0000 Gerrit-HasComments: Yes
