ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails ...................................................................... Patch Set 28: (2 comments) Hi Quanlong, thank you for your patient guidanceļ¼ http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py@505 PS27, Line 505: v.get_value('table_format').file_format == 'text') > The test actaully just creates tables in TEXT format. No need to test on pa Ack http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py@513 PS27, Line 513: ests metadata won't be corrupted after file metadata loading fails : in non-partitioned tables.""" > This comment will be confusing. It sounds like we expect an empty partition Ack -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 28 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 02:18:27 +0000 Gerrit-HasComments: Yes
