Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )
Change subject: IMPALA-11941: (Addendum) ease testing other JDKs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG@10 PS2, Line 10: TEST_JDK > Is TEST_JDK a JDK version number or is it a path to a Java home? It is either. I was being cute, but I could make it two variables instead. http://gerrit.cloudera.org:8080/#/c/20143/2/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java: http://gerrit.cloudera.org:8080/#/c/20143/2/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@77 PS2, Line 77: assumeTrue("Skip if testing a different JDK, as restarting Kudu with JDK 17 fails", This causes a test error, so I think I need to rework this to be a test/cleanup rather than leveraging BeforeClass/AfterClass. -- To view, visit http://gerrit.cloudera.org:8080/20143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00 Gerrit-Change-Number: 20143 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 30 Jun 2023 19:01:30 +0000 Gerrit-HasComments: Yes
