Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads ...................................................................... Patch Set 2: Code-Review+1 (1 comment) LGTM +1. Just a minor question. http://gerrit.cloudera.org:8080/#/c/20145/2/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20145/2/tests/custom_cluster/test_events_custom_configs.py@847 PS2, Line 847: "alter table %s.part partition(p=0) set tblproperties('k'='v')" % unique_database Should we try compaction also here? -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 30 Jun 2023 21:26:23 +0000 Gerrit-HasComments: Yes